Added sankey plot using taxonomy report #96
+1,555
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backend/alignment.go
Outdated
| // Read the taxonomy report | ||
| taxonomyReportPath := filepath.Join(base, "alis_afsp_report") | ||
| taxonomyReport, err := ReadTaxonomyReport(taxonomyReportPath) | ||
| if err != nil { |
There was a problem hiding this comment.
Should this not return an empty taxonomy report if the file does not exist?
backend/alignment.go
Outdated
| @@ -320,13 +330,76 @@ func ReadAlignments[T any, U interface{ ~uint32 | ~int64 }](id Id, entries []U, | |||
| all = append(all, results) | |||
| } | |||
| reader.Delete() | |||
|
|
|||
| // Read the taxonomy report | |||
| taxonomyReportPath := filepath.Join(base, "alis_afsp_report") | |||
There was a problem hiding this comment.
This should probably be "alis_"+db+"_report"
| @@ -106,7 +106,9 @@ | |||
| </v-btn> | |||
| </v-btn-toggle> | |||
| </v-flex> | |||
|
|
|||
| <v-flex> | |||
| <SankeyDiagram :rawData="hits.results[0].taxonomyreport"></SankeyDiagram> | |||
There was a problem hiding this comment.
Does this need a v-if for when hits is still null?
Changes: - Return empty taxonomy report if file doesn't exist (error) - Fixed file path for taxonomy report - Hide sankey when hits is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created SankeyDiagram component and incorporated taxonomy sankey plot to the ResultView.
